Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make HybridPublic folder headers public in Sentry.framework #4384

Closed
wants to merge 2 commits into from
Closed

Make HybridPublic folder headers public in Sentry.framework #4384

wants to merge 2 commits into from

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Oct 1, 2024

📜 Description

We want to support SPM in our sentry flutter framework. In order to do this, we need the SentryHybridSDK classes, which we expose though Cocoapods, to also be available in our SPM package.

This PR is fairly straight forward, as it only exposes the headers as public in the Sentry target.

Another option would be to create a separate target SentryHybrid, the same way as SentrySwiftUI for example. I'm open to suggestions.

💡 Motivation and Context

Unblocks getsentry/sentry-dart#2280

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024 •
edited
Loading

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Make `HybridPublic` folder headers public in `Sentry.framework` ([#4384](https://github.com/getsentry/sentry-cocoa/pull/4384))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against e1d67e0

@denrase denrase mentioned this pull request Oct 1, 2024
Draft
10 tasks
@denrase
Copy link
Collaborator Author

denrase commented Oct 15, 2024

Closed in favour of #4440

@denrase denrase closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipphofmann philipphofmann Awaiting requested review from philipphofmann philipphofmann will be requested when the pull request is marked ready for review philipphofmann is a code owner

@brustolin brustolin Awaiting requested review from brustolin brustolin will be requested when the pull request is marked ready for review brustolin is a code owner

@armcknight armcknight Awaiting requested review from armcknight armcknight will be requested when the pull request is marked ready for review armcknight is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@denrase